Geeklog Bugtracker
Geeklog
Main | My View | View Issues | Change Log | Roadmap | Docs
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000698 [Geeklog] Bugs major always 2008-08-05 13:49 2008-12-14 07:57
Reporter lwc View Status public  
Assigned To THEMike
Priority normal Resolution fixed  
Status resolved   Product Version 1.5.0
Summary 0000698: v1.5.0 calls the right blocks TWICE each time
Description While the left blocks have no such problem in v1.5.0, the right blocks are now called twice each time instead of once.

To prove this, add a debug line to lib-common.php to:

    $blocksql['mssql'] .= $commonsql;
    $result = DB_query( $blocksql );

Here it is with the debug line:

    $blocksql['mssql'] .= $commonsql;
echo "<pre dir=ltr>";print_r($blocksql);echo "";
    $result = DB_query( $blocksql );

You'd then see how 3 SQL arrays are displayed instead of just 2. The latter two are identical and call the right blocks.
Additional Information I signaled this as major because some phpblocks can accept input...like Chatterblock. The bug makes it so such a phpblock gets the info TWICE.

Moreover, Chatterblock even allows to signal deleting the last input when writing a new one, so there's a serious risk of loss of data.
Tags No tags attached.
Target Next Release
Attached Files

- Relationships

-  Notes
User avatar (0000249)
lwc (reporter)
2008-08-05 13:50
edited on: 2008-08-05 14:06

 The debug line was supposed to be:
echo "pre dir=ltr";print_r($blocksql);echo "/pre";

You know what I mean. The HTML tags caused a problem.
User avatar (0000250)
dhaun (administrator)
2008-08-05 13:59

 Interesting. That may also explain why the Shoutbox on geeklog.net records everything twice.
User avatar (0000251)
lwc (reporter)
2008-08-05 14:06
edited on: 2008-08-05 14:08

 I traced the problem to COM_siteFooter, which calls $rblocks twice:

1)
    if( is_array( $custom ))
...
    elseif( $rightblock )
    {
        $rblocks = COM_showBlocks( 'right', $topic );
    }

2)

        if( isset( $what) && is_array( $what ))
...
        else if( !isset( $what ) || ( $what <> 'none' ))
        {
            // Now show any blocks -- need to get the topic if not on home page
            $rblocks = COM_showBlocks( 'right', $topic );
        }

If you'd put echo "test1" after the first "$rblocks =" and echo "test2" after the second, you'd see both "test"s displayed.
User avatar (0000268)
THEMike (developer)
2008-08-16 13:16

 I think this should now be a thing of the past. But my head also hurts.

- Issue History
Date Modified Username Field Change
2008-08-05 13:49 lwc New Issue
2008-08-05 13:50 lwc Note Added: 0000249
2008-08-05 13:51 lwc Note Edited: 0000249
2008-08-05 13:52 lwc Note Edited: 0000249
2008-08-05 13:59 dhaun Note Added: 0000250
2008-08-05 14:06 lwc Note Edited: 0000249
2008-08-05 14:06 lwc Note Edited: 0000249
2008-08-05 14:06 lwc Note Added: 0000251
2008-08-05 14:07 lwc Note Edited: 0000251
2008-08-05 14:08 lwc Note Edited: 0000251
2008-08-10 14:12 dhaun Status new => confirmed
2008-08-16 02:57 dhaun Target => Next Release
2008-08-16 12:10 THEMike Status confirmed => assigned
2008-08-16 12:10 THEMike Assigned To => THEMike
2008-08-16 13:16 THEMike Note Added: 0000268
2008-08-16 13:16 THEMike Status assigned => resolved
2008-08-16 13:16 THEMike Resolution open => fixed
2008-08-16 13:16 THEMike Projection none => minor fix
2008-08-16 13:16 THEMike ETA none => < 1 day
2008-08-16 13:16 THEMike Fixed in Version => CVS
2008-12-14 07:57 dhaun Fixed in Version CVS => 1.5.1

Copyright © 2000 - 2009 Mantis Group
Hosted by pair.com
Powered by Mantis Bugtracker