0000671: .ext-link is hardcoded to the right in styles.css

(0000158)
lwc (reporter)
2008-06-26 07:26

I meant style.css (no plural).

(0000159)
dhaun (administrator)
2008-06-26 14:44

A trivial change in the stylesheet hardly qualifies as a "major" problem ...

(0000171)
THEMike (developer)
2008-06-26 17:47

Showing my ignorance, but how do I switch a GL 1.5.0 instance to ltr?

(0000173)
dhaun (administrator)
2008-06-27 01:58

Use a language file that sets

$LANG_DIRECTION = 'rtl';

Currently, only the Hebrew and Farsi language files do that and they both require you to use UTF-8. For some limited testing, you can also stick it into your english.php, but you should be aware that that is not an exact simulation.

(0000187)
THEMike (developer)
2008-06-28 05:57

Seems this is an IE specific rendering bug, but I assume it would be better to have the icon on the left in RTL rendering?

(0000188)
dhaun (administrator)
2008-06-28 09:04

Yeah, the icon should be on the left of the link for rtl.

Currently, the icon is added as a right-aligned background imags, with some additional right padding to make it visible. I guess we would need two separate ext-link classes then, one per text direction.

The other alternative would be to use CSS to add the icon as part of the page content:

a.ext-link:after {
content: ' ' url(./images/external.png);
}

That way, it would show up on the proper side of the link automatically.

Problems with this:
- browser support for "content:" is somewhat spotty (shouldn't matter too much - it's only cosmetics)
- the icon will be part of the link and therefore will be underlined

(0000206)
THEMike (developer)
2008-07-01 15:54

I've committed a partial fix which looks great in Firefox 3, however, IE7 still looks mashed. But, so do the braces. Which is weird. Someone better than me with CSS fancy a play?

(0000227)
dhaun (administrator)
2008-07-20 16:04

I didn't have much luck with this either. In Firefox 2, the icon ends up under the link text (on the left side) making the text unreadable.

Maybe we should simply drop this again? It's a bit silly in any case: Wikipedia / MediaWiki uses that icon for external links, but in Geeklog, it would also be used for internal links if you added them to the Links plugin. We don't check where the link points to and only slap the class to all links created by the Links plugin.

(0000230)
dhaun (administrator)
2008-07-26 09:45

Cop-out fix: Don't display the icon when the text direction is 'rtl'.

Sorry about that. If anyone can provide a fix that works with all browsers, feel free to re-open the bug ...

(0000254)
lwc (reporter)
2008-08-08 07:44
edited on: 2008-08-08 07:44

I have to re-open this because you undid the solution and brought back the bug.

In other words, Revision 1.38.2.1 cancelled what Revision 1.39 (and 1.40?) did.

Please fix this.

(0000255)
dhaun (administrator)
2008-08-08 08:02

Revision 1.38.2.1 is on a different branch. It therefore can't undo anything in the Trunk.

The "fix" hasn't been ported over to that branch since it was supposed to contain only changes that do not change the themes, database, and language files. Looks like we won't be releasing it anyway, though.

(0000257)
lwc (reporter)
2008-08-08 12:50

I'm not sure what you meant. Were revision 1.39 and 1.40 cancelled? How do you intend to fix this bug then?

I got complaints about both this bug and the multi-listing thing and I had to do something, so I quickly applied revisions 1.39 and 1.40 so as not to make the upgrade look bad.

(0000258)
dhaun (administrator)
2008-08-08 13:31

1.40 is still the current version, to be included with Geeklog 1.5.1. 1.38.2.1 is on a different branch which could have become a Geeklog 1.5.0-1 release.

Now, can we please put this to rest?

(0000392)
lwc (reporter)
2008-10-15 13:28

I'd like to re-open this because I realized there are lots of "text-align:left" in the *general* styles.css - for example, in the TH element.

(0000393)
dhaun (administrator)
2008-10-15 14:03

Can we please stick to one issue per bug? :-/

This bug is about the .ext links, which is a very specific problem involving that icon. If there are other issues elsewhere - okay, but please open a new bug for them then (which you already did anyway, I see).

Notes
(0000158) lwc (reporter) 2008-06-26 07:26	I meant style.css (no plural).

(0000159) dhaun (administrator) 2008-06-26 14:44	A trivial change in the stylesheet hardly qualifies as a "major" problem ...

(0000171) THEMike (developer) 2008-06-26 17:47	Showing my ignorance, but how do I switch a GL 1.5.0 instance to ltr?

(0000173) dhaun (administrator) 2008-06-27 01:58	Use a language file that sets $LANG_DIRECTION = 'rtl'; Currently, only the Hebrew and Farsi language files do that and they both require you to use UTF-8. For some limited testing, you can also stick it into your english.php, but you should be aware that that is not an exact simulation.

(0000187) THEMike (developer) 2008-06-28 05:57	Seems this is an IE specific rendering bug, but I assume it would be better to have the icon on the left in RTL rendering?

(0000188) dhaun (administrator) 2008-06-28 09:04	Yeah, the icon should be on the left of the link for rtl. Currently, the icon is added as a right-aligned background imags, with some additional right padding to make it visible. I guess we would need two separate ext-link classes then, one per text direction. The other alternative would be to use CSS to add the icon as part of the page content: a.ext-link:after { content: ' ' url(./images/external.png); } That way, it would show up on the proper side of the link automatically. Problems with this: - browser support for "content:" is somewhat spotty (shouldn't matter too much - it's only cosmetics) - the icon will be part of the link and therefore will be underlined

(0000206) THEMike (developer) 2008-07-01 15:54	I've committed a partial fix which looks great in Firefox 3, however, IE7 still looks mashed. But, so do the braces. Which is weird. Someone better than me with CSS fancy a play?

(0000227) dhaun (administrator) 2008-07-20 16:04	I didn't have much luck with this either. In Firefox 2, the icon ends up under the link text (on the left side) making the text unreadable. Maybe we should simply drop this again? It's a bit silly in any case: Wikipedia / MediaWiki uses that icon for external links, but in Geeklog, it would also be used for internal links if you added them to the Links plugin. We don't check where the link points to and only slap the class to all links created by the Links plugin.

(0000230) dhaun (administrator) 2008-07-26 09:45	Cop-out fix: Don't display the icon when the text direction is 'rtl'. Sorry about that. If anyone can provide a fix that works with all browsers, feel free to re-open the bug ...

(0000254) lwc (reporter) 2008-08-08 07:44 edited on: 2008-08-08 07:44	I have to re-open this because you undid the solution and brought back the bug. In other words, Revision 1.38.2.1 cancelled what Revision 1.39 (and 1.40?) did. Please fix this.

(0000255) dhaun (administrator) 2008-08-08 08:02	Revision 1.38.2.1 is on a different branch. It therefore can't undo anything in the Trunk. The "fix" hasn't been ported over to that branch since it was supposed to contain only changes that do not change the themes, database, and language files. Looks like we won't be releasing it anyway, though.

(0000257) lwc (reporter) 2008-08-08 12:50	I'm not sure what you meant. Were revision 1.39 and 1.40 cancelled? How do you intend to fix this bug then? I got complaints about both this bug and the multi-listing thing and I had to do something, so I quickly applied revisions 1.39 and 1.40 so as not to make the upgrade look bad.

(0000258) dhaun (administrator) 2008-08-08 13:31	1.40 is still the current version, to be included with Geeklog 1.5.1. 1.38.2.1 is on a different branch which could have become a Geeklog 1.5.0-1 release. Now, can we please put this to rest?

(0000392) lwc (reporter) 2008-10-15 13:28	I'd like to re-open this because I realized there are lots of "text-align:left" in the general styles.css - for example, in the TH element.

(0000393) dhaun (administrator) 2008-10-15 14:03	Can we please stick to one issue per bug? :-/ This bug is about the .ext links, which is a very specific problem involving that icon. If there are other issues elsewhere - okay, but please open a new bug for them then (which you already did anyway, I see).

Issue History
Date Modified	Username	Field	Change
2008-06-26 07:23	lwc	New Issue
2008-06-26 07:25	lwc	File Added: icon-right.zip
2008-06-26 07:26	lwc	Note Added: 0000158
2008-06-26 14:44	dhaun	Note Added: 0000159
2008-06-26 14:44	dhaun	Severity	major => trivial
2008-06-26 14:44	dhaun	Status	new => acknowledged
2008-06-26 14:44	dhaun	Projection	none => tweak
2008-06-26 17:47	THEMike	Note Added: 0000171
2008-06-27 01:58	dhaun	Note Added: 0000173
2008-06-28 05:56	THEMike	File Added: extlink.rar
2008-06-28 05:57	THEMike	Note Added: 0000187
2008-06-28 09:04	dhaun	Note Added: 0000188
2008-06-29 14:04	THEMike	Status	acknowledged => assigned
2008-06-29 14:04	THEMike	Assigned To	=> THEMike
2008-07-01 15:54	THEMike	Note Added: 0000206
2008-07-03 03:30	dhaun	Target	=> Next Release
2008-07-20 16:04	dhaun	Note Added: 0000227
2008-07-26 09:45	dhaun	Note Added: 0000230
2008-07-26 09:45	dhaun	Status	assigned => resolved
2008-07-26 09:45	dhaun	Fixed in Version	=> CVS
2008-07-26 09:45	dhaun	Resolution	open => not fixable
2008-07-27 15:14	dhaun	Relationship added	related to 0000693
2008-08-08 07:44	lwc	Note Added: 0000254
2008-08-08 07:44	lwc	Status	resolved => feedback
2008-08-08 07:44	lwc	Resolution	not fixable => reopened
2008-08-08 07:44	lwc	Note Edited: 0000254
2008-08-08 08:02	dhaun	Note Added: 0000255
2008-08-08 08:02	dhaun	Status	feedback => resolved
2008-08-08 08:02	dhaun	Resolution	reopened => no change required
2008-08-08 12:50	lwc	Note Added: 0000257
2008-08-08 12:50	lwc	Status	resolved => feedback
2008-08-08 12:50	lwc	Resolution	no change required => reopened
2008-08-08 13:31	dhaun	Note Added: 0000258
2008-08-08 13:31	dhaun	Status	feedback => resolved
2008-08-08 13:31	dhaun	Resolution	reopened => no change required
2008-10-15 13:28	lwc	Note Added: 0000392
2008-10-15 13:28	lwc	Status	resolved => feedback
2008-10-15 13:28	lwc	Resolution	no change required => reopened
2008-10-15 14:03	dhaun	Note Added: 0000393
2008-10-15 14:03	dhaun	Status	feedback => resolved
2008-10-15 14:03	dhaun	Resolution	reopened => no change required