0000619: Plugins should be able to control moderation on their own

Geeklog Bugtracker

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000619

[Geeklog] Feature Requests

tweak

N/A

2008-05-04 00:19

2009-04-08 04:20

Reporter

jmucchiello

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

feedback

Product Version

Summary

0000619: Plugins should be able to control moderation on their own

Description

Calls to plugin_itemlist_$type require a return of a plugin object (should be called a moderation object) and impose various strict requirements on a plugin's database layout. It would be nice if the return from plugin_itemlist_$type could also be html. When the return is an object, process it as currently coded. When the return type is a string, just append it to the current output.

Additional Information

    if ((strlen ($type) > 0) && ($type <> 'story')) {
        $function = 'plugin_itemlist_' . $type;
        if (function_exists ($function)) {
            // Great, we found the plugin, now call its itemlist method
            $list = $function(); // new
            if (is_string($list)) { // new
                return $list; // new
            } // new
            $plugin = new Plugin();
            $plugin = $list;
            if (isset ($plugin)) {
                $helpfile = $plugin->submissionhelpfile;
                $sql = $plugin->getsubmissionssql;
                $H = $plugin->submissionheading;
                $section_title = $plugin->submissionlabel;
                $section_help = $helpfile;
                $isplugin = true;
            }
        }

Tags

No tags attached.

Target

Future Release

Attached Files

Relationships

Notes
(0000239) jmucchiello (reporter) 2008-07-30 22:48	On further testing (and since the CSRF token stuff now exists), here's the current code change: $plugin = new Plugin(); $plugin = $function(); if (isset ($plugin)) { becomes $plugin = new Plugin(); $plugin = $function($token); if (is_string($plugin)) { return '<div class="block-box">'.$plugin.'</div>'; } elseif (is_object($plugin)) {

(0000322) THEMike (developer) 2008-09-14 05:23	Easy enough to integrate into 1.5.2

Issue History
Date Modified	Username	Field	Change
2008-05-04 00:19	jmucchiello	New Issue
2008-05-04 05:46	dhaun	Status	new => feedback
2008-07-30 22:48	jmucchiello	Note Added: 0000239
2008-09-14 05:23	THEMike	Target	=> not specified
2008-09-14 05:23	THEMike	Note Added: 0000322
2008-09-14 05:23	THEMike	Target Version	=> 1.5.2
2008-12-18 05:12	dhaun	Target	not specified => Future Release
2008-12-18 05:12	dhaun	Target Version	1.5.2 => 1.6.0
2009-04-08 04:20	dhaun	Target Version	1.6.0 =>

Hosted by pair.com