0000607: Config: Mail Settings[auth] should be a dropdown

(0000029)
dhaun (administrator)
2008-04-23 15:50

From the code, it looks like it wasn't prepared for arrays of mixed types. An array of all texts works, as do those of all boolean (default permissions, for example).

I guess there isn't much we can do at this time - it'll probably have to wait for after the 1.5.0 release.

Workaround: Use 1 instead of true.

(0000030)
kantai (developer)
2008-04-24 08:59

"From the code, it looks like it wasn't prepared for arrays of mixed types. An array of all texts works, as do those of all boolean (default permissions, for example)."

That's correct.

(0000321)
THEMike (developer)
2008-09-14 05:21

I think this is a really simple change in the configuration variables table and it will automatically become a drop down.

(0000429)
dhaun (administrator)
2008-11-22 13:34

Hey Mike, I don't really see that "really simple change in the configuration variables table". The mail settings are an array of strings, with the exception of the 'auth' flag. The config class can't handle such mixed array currently, from what I can see.

What am I missing?

(0000641)
dhaun (administrator)
2009-04-10 17:40

Pushing this back into the Future

(0000680)
dhaun (administrator)
2009-04-19 13:05

Mail Settings[backend] should also be a dropdown (smtp, sendmail, mail).

(0000684)
m_c (reporter)
2009-04-19 18:15

It's an outcome of ignoring the 1NF (first normal form) in the database - that is single cell's data atomicity. All the mail settings were stuffed into one single config value and became impossible to control.

It was designed this way, because it was quick & easy to pass the whole mail_settings array to the Mail::factory in COM_mail().

I've made a fix, which...

/**
* Converts the old mail_settings multi-setting into several atomic settings.
*
* It adds new mail_xxx fields to the configuration, transfers the settings
* from the existing mail_settings field and finally deletes the mail_settings
* entry in the config.
*/

I've attached the diff's in both non- and readable forms and also the migration files. Overall, those cover:

* both MySQL and MsSQL migration files
* config-install.php
* english UTF-8 language file
* all the relevant references throughout the code
* documentation

(0000685)
m_c (reporter)
2009-04-19 18:20

Oh, by the way - the fix includes the desired dropdowns. :-)

Issue History
Date Modified	Username	Field	Change
2008-04-15 15:06	dhaun	New Issue
2008-04-15 15:07	dhaun	Status	new => confirmed
2008-04-23 15:50	dhaun	Note Added: 0000029
2008-04-24 08:59	kantai	Note Added: 0000030
2008-04-24 09:06	dhaun	Status	confirmed => assigned
2008-04-24 09:06	dhaun	Assigned To	=> kantai
2008-06-22 14:37	kantai	Assigned To	kantai => dhaun
2008-09-14 05:21	THEMike	Target	=> not specified
2008-09-14 05:21	THEMike	Note Added: 0000321
2008-09-14 05:21	THEMike	Target Version	=> 1.5.2
2008-11-22 13:31	dhaun	Assigned To	dhaun =>
2008-11-22 13:31	dhaun	Assigned To	=> THEMike
2008-11-22 13:34	dhaun	Note Added: 0000429
2008-12-19 08:59	dhaun	Target	not specified => Future Release
2008-12-19 08:59	dhaun	Target Version	1.5.2 => 1.6.0
2009-04-10 17:40	dhaun	Note Added: 0000641
2009-04-10 17:40	dhaun	Assigned To	THEMike =>
2009-04-10 17:40	dhaun	Status	assigned => confirmed
2009-04-10 17:40	dhaun	Target Version	1.6.0 => 1.6.1
2009-04-19 13:05	dhaun	Note Added: 0000680
2009-04-19 18:15	m_c	Note Added: 0000684
2009-04-19 18:15	m_c	File Added: gl_mail_settings_tweak.patch
2009-04-19 18:16	m_c	File Added: gl_mail_settings_tweak_no_context.patch
2009-04-19 18:18	m_c	File Added: mxsql_1.5.2_to_1.6.0.zip
2009-04-19 18:20	m_c	Note Added: 0000685
2009-10-31 05:06	dhaun	Target Version	1.6.1 => Future

Notes
(0000029) dhaun (administrator) 2008-04-23 15:50	From the code, it looks like it wasn't prepared for arrays of mixed types. An array of all texts works, as do those of all boolean (default permissions, for example). I guess there isn't much we can do at this time - it'll probably have to wait for after the 1.5.0 release. Workaround: Use 1 instead of true.

(0000030) kantai (developer) 2008-04-24 08:59	"From the code, it looks like it wasn't prepared for arrays of mixed types. An array of all texts works, as do those of all boolean (default permissions, for example)." That's correct.

(0000321) THEMike (developer) 2008-09-14 05:21	I think this is a really simple change in the configuration variables table and it will automatically become a drop down.

(0000429) dhaun (administrator) 2008-11-22 13:34	Hey Mike, I don't really see that "really simple change in the configuration variables table". The mail settings are an array of strings, with the exception of the 'auth' flag. The config class can't handle such mixed array currently, from what I can see. What am I missing?

(0000641) dhaun (administrator) 2009-04-10 17:40	Pushing this back into the Future

(0000680) dhaun (administrator) 2009-04-19 13:05	Mail Settings[backend] should also be a dropdown (smtp, sendmail, mail).

(0000684) m_c (reporter) 2009-04-19 18:15	It's an outcome of ignoring the 1NF (first normal form) in the database - that is single cell's data atomicity. All the mail settings were stuffed into one single config value and became impossible to control. It was designed this way, because it was quick & easy to pass the whole mail_settings array to the Mail::factory in COM_mail(). I've made a fix, which... /** * Converts the old mail_settings multi-setting into several atomic settings. * * It adds new mail_xxx fields to the configuration, transfers the settings * from the existing mail_settings field and finally deletes the mail_settings * entry in the config. / I've attached the diff's in both non- and readable forms and also the migration files. Overall, those cover: both MySQL and MsSQL migration files * config-install.php * english UTF-8 language file * all the relevant references throughout the code * documentation

(0000685) m_c (reporter) 2009-04-19 18:20	Oh, by the way - the fix includes the desired dropdowns. :-)

Relationships